From 2784f73721c962291fa4500bc063d8c95523d80c Mon Sep 17 00:00:00 2001
From: Joerg Wunsch <j@uriah.heep.sax.de>
Date: Sun, 14 Apr 2024 22:18:55 +0200
Subject: [PATCH] Improve device selection

Make the combo box editable, and apply a QValidator subclass
to it so the users can type partial device names.
---
 src/python/adgui.py  | 48 ++++++++++++++++++++++++++++++++++++++++++++
 src/python/device.ui |  7 +++++--
 2 files changed, 53 insertions(+), 2 deletions(-)

diff --git a/src/python/adgui.py b/src/python/adgui.py
index 39499431..c79c1666 100755
--- a/src/python/adgui.py
+++ b/src/python/adgui.py
@@ -432,6 +432,47 @@ class FusePopup():
         self.lineedit.clear()
         self.lineedit.setText(f"{fuseval:02X}")
 
+class listValidator(QValidator):
+
+    def __init__(self, liste):
+        super().__init__()
+        self.list = liste
+
+    def validate(self, string, position):
+        if string == "":
+            # empty string could always become a real match
+            return QValidator.Intermediate, string, position
+
+        s = string.lower()
+
+        for i in self.list:
+            i = i.lower()
+
+            if i == s:
+                # exact match
+                return QValidator.Acceptable, string, position
+
+            if i.find(s) != -1:
+                # could become a real match some day
+                return QValidator.Intermediate, string, position
+
+        # no match at all, invalid input
+        return QValidator.Invalid, string, position
+
+    def fixup(self, string):
+        # possibly change case of string for an exact match
+        s = string.lower()
+
+        for i in self.list:
+            if s == i.lower():
+                return i
+        # hmm, not found - use the first partial match
+        for i in self.list:
+            if i.lower().find(s) != -1:
+                return i
+
+        # nothing at all
+        return string
 
 class adgui(QObject):
     def __init__(self, argv):
@@ -745,11 +786,15 @@ class adgui(QObject):
         fams = list(self.devices.keys())
         #fams.sort()
         self.device.devices.clear()
+        l = []
         for f in fams:
             obj = eval('self.device.' + f + '.isChecked()')
             if obj:
                 for d in self.devices[f]:
                     self.device.devices.addItem(d)
+                    l.append(d)
+        self.dev_validator = listValidator(l)
+        self.device.devices.setValidator(self.dev_validator)
 
     def update_programmer_cb(self):
         fams = list(self.programmers.keys())
@@ -812,6 +857,9 @@ class adgui(QObject):
     def device_selected(self):
         self.dev_selected = self.device.devices.currentText()
         self.dev = ad.locate_part(ad.cvar.part_list, self.dev_selected)
+        if not self.dev:
+            self.log(f"Invalid device selection: {self.dev_selected}")
+            return
         self.log(f"Selected device: {self.dev_selected}")
         self.settings.setValue('file/device', self.dev_selected)
         self.update_device_info()
diff --git a/src/python/device.ui b/src/python/device.ui
index 5d9b272f..9f9a6ce2 100644
--- a/src/python/device.ui
+++ b/src/python/device.ui
@@ -9,8 +9,8 @@
    <rect>
     <x>0</x>
     <y>0</y>
-    <width>398</width>
-    <height>217</height>
+    <width>411</width>
+    <height>240</height>
    </rect>
   </property>
   <property name="windowTitle">
@@ -47,6 +47,9 @@
        <height>0</height>
       </size>
      </property>
+     <property name="editable">
+      <bool>true</bool>
+     </property>
     </widget>
    </item>
    <item row="1" column="3">