From 69c5c4673b59761f73bda0ecaf8029e153b74bd0 Mon Sep 17 00:00:00 2001 From: stefanrueger Date: Sat, 3 May 2025 14:41:49 +0200 Subject: [PATCH] Clarify UPDI initilisation --- src/pickit5.c | 27 +++++++++++++-------------- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/src/pickit5.c b/src/pickit5.c index 0af0a4cf..eb522414 100644 --- a/src/pickit5.c +++ b/src/pickit5.c @@ -1036,21 +1036,20 @@ static int pickit5_initialize(const PROGRAMMER *pgm, const AVRPART *p) { if(is_updi(pgm)) { // UPDI got it's own init as it is well enough documented to select if(pickit5_updi_init(pgm, p, v_target) < 0) // the CLKDIV based on the voltage and requested baud return -1; - } else { - - // JTAG __requires__ setting the speed before program enable - pickit5_set_sck_period(pgm, 1.0 / my.actual_pgm_clk); - - if(pickit5_program_enable(pgm, p) < 0) { - pmsg_error("failed to enable programming mode\n"); - return -1; - } - if(pickit5_read_dev_id(pgm, p) < 0) { - pmsg_error("failed to obtain device ID\n"); - return -1; - } - + return 0; } + + // JTAG __requires__ setting the speed before program enable + pickit5_set_sck_period(pgm, 1.0 / my.actual_pgm_clk); + if(pickit5_program_enable(pgm, p) < 0) { + pmsg_error("failed to enable programming mode\n"); + return -1; + } + if(pickit5_read_dev_id(pgm, p) < 0) { + pmsg_error("failed to obtain device ID\n"); + return -1; + } + return 0; }