From 7fcd7830cbfca8961b81e91c8f07e418c81e1dde Mon Sep 17 00:00:00 2001 From: Hans Date: Tue, 4 Mar 2025 11:22:46 +0100 Subject: [PATCH] Optimization and tweaks based on feedback from PR #1947 --- src/pickit5.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/pickit5.c b/src/pickit5.c index c5dd3d76..c3f8d05f 100644 --- a/src/pickit5.c +++ b/src/pickit5.c @@ -641,12 +641,10 @@ static int pickit5_open(PROGRAMMER *pgm, const char *port) { pgm->fd.usb.eep = USBDEV_EVT_EP_READ_3; const char *pgm_suffix = strchr(pgmid, '_')? strchr(pgmid, '_'): ""; - char part_option[32] = {}; // 32 should be enough + char part_option[128] = {0}; if(partdesc) - snprintf(part_option, 31, "-p %s ", partdesc); - else - strcpy(part_option, ""); + snprintf(part_option, sizeof(part_option), "-p %s ", partdesc); // Use LIBHIDAPI to connect to SNAP/PICkit4 if present. // For some reason, chances are smaller to get