From 3c32572a27df779578e2d6f9a07dd17fe31dc2e2 Mon Sep 17 00:00:00 2001 From: Anshul Dalal Date: Thu, 12 Mar 2026 10:30:12 +0530 Subject: [PATCH] common: splash_source: fix cryptic error messages Some error messages emitted while loading the splash image are too cryptic and don't provide any insights into the failure being a splash related issue, such as 'Error (-2): cannot determine file size' etc. This patch fixes the error codes by adding the function name to the error print. Signed-off-by: Anshul Dalal [trini: Add missing ',' and wrap to 80-width] Signed-off-by: Tom Rini --- common/splash_source.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/common/splash_source.c b/common/splash_source.c index 0710e302ba1..e02f9be05e4 100644 --- a/common/splash_source.c +++ b/common/splash_source.c @@ -159,12 +159,12 @@ static int splash_select_fs_dev(struct splash_location *location) res = -ENODEV; break; default: - printf("Error: unsupported location storage.\n"); + printf("Error: %s: unsupported location storage.\n", __func__); return -ENODEV; } if (res) - printf("Error: could not access storage.\n"); + printf("Error: %s: could not access storage.\n", __func__); return res; } @@ -284,7 +284,8 @@ static int splash_load_fs(struct splash_location *location, ulong bmp_load_addr) res = fs_size(splash_file, &bmp_size); if (res) { - printf("Error (%d): cannot determine file size\n", res); + printf("Error: %s: cannot determine file size (%d)\n", + __func__, res); goto out; }