From 3c34fd46b6efd0501662ba3f0aeff2aeac9a584d Mon Sep 17 00:00:00 2001 From: Ilias Apalodimas Date: Fri, 29 Aug 2025 11:16:15 +0300 Subject: [PATCH 1/8] tools: fdtgrep: Mark util_version() as static The function is only used locally. Enabling -Wmissing-prototypes triggers a warning. Mark it as static. Signed-off-by: Ilias Apalodimas --- tools/fdtgrep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/fdtgrep.c b/tools/fdtgrep.c index 037176bc9ef..6372defedc2 100644 --- a/tools/fdtgrep.c +++ b/tools/fdtgrep.c @@ -1109,7 +1109,7 @@ void util_usage(const char *errmsg, const char *synopsis, util_usage(errmsg, usage_synopsis, usage_short_opts, \ usage_long_opts, usage_opts_help) -void util_version(void) +static void util_version(void) { printf("Version: %s\n", "(U-Boot)"); exit(0); From 9fe4e088f3d2ba15323ae4bff7f6b592152e326c Mon Sep 17 00:00:00 2001 From: Ilias Apalodimas Date: Fri, 29 Aug 2025 11:16:16 +0300 Subject: [PATCH 2/8] tools: fdtgrep: Mark util_usage() as static The function is only used locally. Enabling -Wmissing-prototypes triggers a warning. Mark it as static. Signed-off-by: Ilias Apalodimas --- tools/fdtgrep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/fdtgrep.c b/tools/fdtgrep.c index 6372defedc2..b4c041070f5 100644 --- a/tools/fdtgrep.c +++ b/tools/fdtgrep.c @@ -1040,7 +1040,7 @@ static const char * const usage_opts_help[] = { #define util_getopt_long() getopt_long(argc, argv, usage_short_opts, \ usage_long_opts, NULL) -void util_usage(const char *errmsg, const char *synopsis, +static void util_usage(const char *errmsg, const char *synopsis, const char *short_opts, struct option const long_opts[], const char * const opts_help[]) { From 867d762bc515850b00245cbcf21cf2b2d39a2a5d Mon Sep 17 00:00:00 2001 From: Ilias Apalodimas Date: Fri, 29 Aug 2025 11:16:17 +0300 Subject: [PATCH 3/8] tools: mkimage: Mark copy_datafile() as static The function is only used locally. Enabling -Wmissing-prototypes triggers a warning. Mark it as static. Signed-off-by: Ilias Apalodimas --- tools/mkimage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/mkimage.c b/tools/mkimage.c index 361711c53b2..847453970ab 100644 --- a/tools/mkimage.c +++ b/tools/mkimage.c @@ -445,7 +445,7 @@ static void verify_image(const struct image_type_params *tparams) (void)close(ifd); } -void copy_datafile(int ifd, char *file) +static void copy_datafile(int ifd, char *file) { if (!file) return; From 3ae031135da1f21ec22e20fac5d7ba9776487166 Mon Sep 17 00:00:00 2001 From: Ilias Apalodimas Date: Fri, 29 Aug 2025 11:16:18 +0300 Subject: [PATCH 4/8] tools: rkcommon: Mark rkcommon_is_header_v2() as static The function is only used locally. Enabling -Wmissing-prototypes triggers a warning. Mark it as static. Signed-off-by: Ilias Apalodimas Reviewed-by: Quentin Schulz --- tools/rkcommon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/rkcommon.c b/tools/rkcommon.c index a0caa029cc0..d191ea72c63 100644 --- a/tools/rkcommon.c +++ b/tools/rkcommon.c @@ -279,7 +279,7 @@ bool rkcommon_need_rc4_spl(struct image_tool_params *params) return info->spl_rc4; } -bool rkcommon_is_header_v2(struct image_tool_params *params) +static bool rkcommon_is_header_v2(struct image_tool_params *params) { struct spl_info *info = rkcommon_get_spl_info(params->imagename); From 5ab15814e8f051968a4da8c96339ff0c80c5f811 Mon Sep 17 00:00:00 2001 From: Ilias Apalodimas Date: Fri, 29 Aug 2025 11:16:19 +0300 Subject: [PATCH 5/8] tool: fit_info: Mark usage() as static The function is only used locally. Enabling -Wmissing-prototypes triggers a warning. Mark it as static. Signed-off-by: Ilias Apalodimas --- tools/fit_info.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/fit_info.c b/tools/fit_info.c index b2642ec5b76..c9e4236d09f 100644 --- a/tools/fit_info.c +++ b/tools/fit_info.c @@ -26,7 +26,7 @@ #include #include -void usage(char *cmdname) +static void usage(char *cmdname) { fprintf(stderr, "Usage: %s -f fit file -n node -p property\n" " -f ==> set fit file which is used'\n" From 39f7af39bb2e7e03ea4621e57a976d41dcaaf0a6 Mon Sep 17 00:00:00 2001 From: Ilias Apalodimas Date: Fri, 29 Aug 2025 11:16:20 +0300 Subject: [PATCH 6/8] tools: fit_check_sign: Mark usage() as static The function is only used locally. Enabling -Wmissing-prototypes triggers a warning. Mark it as static. Signed-off-by: Ilias Apalodimas --- tools/fit_check_sign.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/fit_check_sign.c b/tools/fit_check_sign.c index 32d0fdb8829..ab3266aff20 100644 --- a/tools/fit_check_sign.c +++ b/tools/fit_check_sign.c @@ -23,7 +23,7 @@ #include #include -void usage(char *cmdname) +static void usage(char *cmdname) { fprintf(stderr, "Usage: %s -f fit file -k key file -c config name\n" " -f ==> set fit file which should be checked'\n" From f006837eada06cdf41b9935eb6c73618e4ae0bf0 Mon Sep 17 00:00:00 2001 From: Ilias Apalodimas Date: Fri, 29 Aug 2025 11:16:21 +0300 Subject: [PATCH 7/8] tools: imx8mimage: Mark build_image() as static The function is only used locally. Enabling -Wmissing-prototypes triggers a warning. Mark it as static. Signed-off-by: Ilias Apalodimas --- tools/imx8mimage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/imx8mimage.c b/tools/imx8mimage.c index 0f24ba75c0f..fe1aff35b4d 100644 --- a/tools/imx8mimage.c +++ b/tools/imx8mimage.c @@ -475,7 +475,7 @@ static int generate_fspi_header (int ifd) } #endif -void build_image(int ofd) +static void build_image(int ofd) { int file_off, header_hdmi_off = 0, header_image_off; From 1e73651a71d1cf2a718b9a8250a794d626b9eecb Mon Sep 17 00:00:00 2001 From: Ilias Apalodimas Date: Fri, 29 Aug 2025 11:16:22 +0300 Subject: [PATCH 8/8] tools: imx8image: Mark imx8mimage_check_params() as static The function is only used locally. Enabling -Wmissing-prototypes triggers a warning. Mark it as static. Signed-off-by: Ilias Apalodimas --- tools/imx8mimage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/imx8mimage.c b/tools/imx8mimage.c index fe1aff35b4d..3e974923652 100644 --- a/tools/imx8mimage.c +++ b/tools/imx8mimage.c @@ -49,7 +49,7 @@ static uint32_t get_cfg_value(char *token, char *name, int linenr) return value; } -int imx8mimage_check_params(struct image_tool_params *params) +static int imx8mimage_check_params(struct image_tool_params *params) { return 0; }