From d3edeaf96812396c60fb7d7342016de0e20d8f18 Mon Sep 17 00:00:00 2001 From: David Lechner Date: Thu, 19 Mar 2026 15:00:07 -0500 Subject: [PATCH] arm: mediatek: mt8183: remove call to fdtdec_setup_memory_banksize() Remove an incorrect call to fdtdec_setup_memory_banksize() in dram_init() for mt8183. fdtdec_setup_memory_banksize() populates gd->bd->bi_dram[bank].start and gd->bd->bi_dram[bank].size base on the "memory" node in the device tree. However, calling it from dram_init() is too early because gd->bd has not been allocated yet. gd->bd->bi_dram[0].start and gd->bd->bi_dram[0].size are already correctly initialized later in dram_init_banksize(), so we do not need to replace the removed function call with anything else. Reviewed-by: Julien Stephan Tested-by: Julien Stephan Link: https://patch.msgid.link/20260319-mtk-init-fix-dram-v1-4-6171ec141f40@baylibre.com Signed-off-by: David Lechner --- arch/arm/mach-mediatek/mt8183/init.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/arch/arm/mach-mediatek/mt8183/init.c b/arch/arm/mach-mediatek/mt8183/init.c index 5c3c96e126b..8797261368e 100644 --- a/arch/arm/mach-mediatek/mt8183/init.c +++ b/arch/arm/mach-mediatek/mt8183/init.c @@ -20,12 +20,6 @@ DECLARE_GLOBAL_DATA_PTR; int dram_init(void) { - int ret; - - ret = fdtdec_setup_memory_banksize(); - if (ret) - return ret; - return fdtdec_setup_mem_size_base(); }