mirror of
https://source.denx.de/u-boot/u-boot.git
synced 2026-06-02 09:46:37 +03:00
probe_ram_size_by_alias() detects whether a probe address still aliases
a lower address by writing through one address and reading through the
other.
On i.MX95 this occasionally reported a false non-alias when the alias
read happened immediately after the write.
A memory barrier alone, mb(), was tested but did not make the failure go
away. This suggests that ordering the CPU accesses is not sufficient for
this probe, likely because the issue is in the path to the memory
controller rather than in the core itself.
Read the written address back before checking the alias address. This
appears to force the write to become observable at the probe address
before using the alias read to decide whether the tested address range
exists.
If the readback does not match the written pattern, restore the saved
value and continue with the next check. This keeps the probe robust for
addresses that do not reliably retain the test pattern.
Fixes: 0977448b45 ("common: memsize: add RAM size probe based on alias detection")
Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
229 lines
5.3 KiB
C
229 lines
5.3 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* (C) Copyright 2004
|
|
* Wolfgang Denk, DENX Software Engineering, wd@denx.de.
|
|
*/
|
|
|
|
#include <config.h>
|
|
#include <init.h>
|
|
#include <asm/global_data.h>
|
|
#include <cpu_func.h>
|
|
#include <stdint.h>
|
|
|
|
DECLARE_GLOBAL_DATA_PTR;
|
|
|
|
#ifdef CONFIG_SYS_CACHELINE_SIZE
|
|
# define MEMSIZE_CACHELINE_SIZE CONFIG_SYS_CACHELINE_SIZE
|
|
#else
|
|
/* Just use the greatest cache flush alignment requirement I'm aware of */
|
|
# define MEMSIZE_CACHELINE_SIZE 128
|
|
#endif
|
|
|
|
#ifdef __PPC__
|
|
/*
|
|
* At least on G2 PowerPC cores, sequential accesses to non-existent
|
|
* memory must be synchronized.
|
|
*/
|
|
# include <asm/io.h> /* for sync() */
|
|
#else
|
|
# define sync() /* nothing */
|
|
#endif
|
|
|
|
static void dcache_flush_invalidate(volatile long *p)
|
|
{
|
|
uintptr_t start, stop;
|
|
start = ALIGN_DOWN((uintptr_t)p, MEMSIZE_CACHELINE_SIZE);
|
|
stop = start + MEMSIZE_CACHELINE_SIZE;
|
|
flush_dcache_range(start, stop);
|
|
invalidate_dcache_range(start, stop);
|
|
}
|
|
|
|
/*
|
|
* Check memory range for valid RAM. A simple memory test determines
|
|
* the actually available RAM size between addresses `base' and
|
|
* `base + maxsize'.
|
|
*/
|
|
long get_ram_size(long *base, long maxsize)
|
|
{
|
|
volatile long *addr;
|
|
long save[BITS_PER_LONG - 1];
|
|
long save_base;
|
|
long cnt;
|
|
long val;
|
|
long size;
|
|
int i = 0;
|
|
int dcache_en = 0;
|
|
|
|
if (!CONFIG_IS_ENABLED(SYS_DCACHE_OFF))
|
|
dcache_en = dcache_status();
|
|
|
|
for (cnt = (maxsize / sizeof(long)) >> 1; cnt > 0; cnt >>= 1) {
|
|
addr = base + cnt; /* pointer arith! */
|
|
sync();
|
|
save[i++] = *addr;
|
|
sync();
|
|
*addr = ~cnt;
|
|
if (dcache_en)
|
|
dcache_flush_invalidate(addr);
|
|
}
|
|
|
|
addr = base;
|
|
sync();
|
|
save_base = *addr;
|
|
sync();
|
|
*addr = 0;
|
|
|
|
sync();
|
|
if (dcache_en)
|
|
dcache_flush_invalidate(addr);
|
|
|
|
if ((val = *addr) != 0) {
|
|
/* Restore the original data before leaving the function. */
|
|
sync();
|
|
*base = save_base;
|
|
for (cnt = 1; cnt < maxsize / sizeof(long); cnt <<= 1) {
|
|
addr = base + cnt;
|
|
sync();
|
|
*addr = save[--i];
|
|
if (dcache_en)
|
|
dcache_flush_invalidate(addr);
|
|
}
|
|
return (0);
|
|
}
|
|
|
|
for (cnt = 1; cnt < maxsize / sizeof(long); cnt <<= 1) {
|
|
addr = base + cnt; /* pointer arith! */
|
|
val = *addr;
|
|
*addr = save[--i];
|
|
if (dcache_en)
|
|
dcache_flush_invalidate(addr);
|
|
if (val != ~cnt) {
|
|
size = cnt * sizeof(long);
|
|
/*
|
|
* Restore the original data
|
|
* before leaving the function.
|
|
*/
|
|
for (cnt <<= 1;
|
|
cnt < maxsize / sizeof(long);
|
|
cnt <<= 1) {
|
|
addr = base + cnt;
|
|
*addr = save[--i];
|
|
if (dcache_en)
|
|
dcache_flush_invalidate(addr);
|
|
}
|
|
/* warning: don't restore save_base in this case,
|
|
* it is already done in the loop because
|
|
* base and base+size share the same physical memory
|
|
* and *base is saved after *(base+size) modification
|
|
* in first loop
|
|
*/
|
|
return (size);
|
|
}
|
|
}
|
|
*base = save_base;
|
|
if (dcache_en)
|
|
dcache_flush_invalidate(base);
|
|
|
|
return (maxsize);
|
|
}
|
|
|
|
/**
|
|
* probe_ram_size_by_alias() - Detect RAM size using known alias addresses
|
|
* @checks: Array of RAM alias probe descriptors, terminated by a NULL
|
|
* @probe_addr entry
|
|
*
|
|
* Probe RAM size by writing a test pattern to each @probe_addr and checking
|
|
* whether the same pattern does not appear at the corresponding @alias_addr.
|
|
* This is useful on systems where address wrap-around does not alias to the
|
|
* base of memory in a linear way, so get_ram_size() cannot be used directly.
|
|
* It is also useful on systems where the base of the physical memory cannot
|
|
* be safely accessed, so get_ram_size() cannot be used at all.
|
|
*
|
|
* Return: The size associated with the first matching entry, or 0 if no match
|
|
* is found.
|
|
*/
|
|
long probe_ram_size_by_alias(const struct ram_alias_check *checks)
|
|
{
|
|
long save[2];
|
|
long pat;
|
|
int dcache_en = 0;
|
|
long ret = 0;
|
|
|
|
if (!CONFIG_IS_ENABLED(SYS_DCACHE_OFF))
|
|
dcache_en = dcache_status();
|
|
|
|
while (checks->probe_addr && !ret) {
|
|
volatile long *d = checks->probe_addr;
|
|
volatile long *s = checks->alias_addr;
|
|
|
|
save[0] = *s;
|
|
save[1] = *d;
|
|
/* Ensure s is written and not cached */
|
|
if (dcache_en)
|
|
dcache_flush_invalidate(s);
|
|
|
|
pat = ~save[0];
|
|
*d = pat;
|
|
sync();
|
|
if (dcache_en)
|
|
dcache_flush_invalidate(d);
|
|
|
|
/*
|
|
* Make sure the test pattern is observable at the probe
|
|
* address before checking whether it is also visible through
|
|
* the alias address.
|
|
*/
|
|
if (*d != pat) {
|
|
*d = save[1];
|
|
sync();
|
|
if (dcache_en)
|
|
dcache_flush_invalidate(d);
|
|
checks++;
|
|
continue;
|
|
}
|
|
|
|
if (*s != pat)
|
|
ret = checks->size;
|
|
|
|
/* Restore content */
|
|
*d = save[1];
|
|
sync();
|
|
if (dcache_en)
|
|
dcache_flush_invalidate(d);
|
|
|
|
*s = save[0];
|
|
sync();
|
|
if (dcache_en)
|
|
dcache_flush_invalidate(s);
|
|
|
|
checks++;
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
phys_size_t __weak get_effective_memsize(void)
|
|
{
|
|
phys_size_t ram_size = gd->ram_size;
|
|
|
|
#ifdef CONFIG_MPC85xx
|
|
/*
|
|
* Check for overflow and limit ram size to some representable value.
|
|
* It is required that ram_base + ram_size must be representable by
|
|
* phys_size_t type and must be aligned by direct access, therefore
|
|
* calculate it from last 4kB sector which should work as alignment
|
|
* on any platform.
|
|
*/
|
|
if (gd->ram_base + ram_size < gd->ram_base)
|
|
ram_size = ((phys_size_t)~0xfffULL) - gd->ram_base;
|
|
#endif
|
|
|
|
#ifndef CFG_MAX_MEM_MAPPED
|
|
return ram_size;
|
|
#else
|
|
/* limit stack to what we can reasonable map */
|
|
return ((ram_size > CFG_MAX_MEM_MAPPED) ?
|
|
CFG_MAX_MEM_MAPPED : ram_size);
|
|
#endif
|
|
}
|