Heinrich Schuchardt 163f9d04fb efi_loader: correctly check if the HTTP protocol is found ...

In function efi_http_service_binding_destroy_child() phandler is created as
as a local variable. If efi_search_protocol() fails, phandler will hold a
random value from the stack. Even it is not zero, we must not use it.

If efi_search_protocol() succeeds, the pointer has already be dereferenced,
so checking against NULL makes not sense here.

If ChildHandle is not a valid UEFI handle, we must return
EFI_INVALID_PARAMETER.

Use a single location for EFI_EXIT().

Addresses-Coverity-ID: CID 531974 (Unchecked return value)
Fixes: 5753dc3f65 ("efi_loader: Prevent dereference of uninitialised variable")
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>

2025-10-18 11:41:32 +02:00

..

acpi

Merge patch series "Switch to using $(PHASE_) in Makefiles"

2025-04-11 12:16:49 -06:00

aes

Kbuild: Always use $(PHASE_)

2025-04-11 12:16:44 -06:00

at91

lib: Remove <common.h> inclusion from these files

2023-12-21 08:54:37 -05:00

blake2

lib: Remove duplicate newlines

2024-07-15 12:12:18 -06:00

bzip2

lib: Remove duplicate newlines

2024-07-15 12:12:18 -06:00

crypt

lib: Remove duplicate newlines

2024-07-15 12:12:18 -06:00

crypto

Kbuild: Always use $(PHASE_)

2025-04-11 12:16:44 -06:00

dhry

lib: Remove duplicate newlines

2024-07-15 12:12:18 -06:00

ecdsa

ecdsa: fix segfault in mkimage when "-r" option is not set

2025-07-14 15:16:45 -06:00

efi

efi: Create a new CONFIG_EFI

2025-07-26 07:34:31 +02:00

efi_client

efi: Create a new CONFIG_EFI

2025-07-26 07:34:31 +02:00

efi_driver

efi_loader: Separate device path into its own header

2025-05-25 11:27:18 +02:00

efi_loader

efi_loader: correctly check if the HTTP protocol is found

2025-10-18 11:41:32 +02:00

efi_selftest

efi_selftest: fix ESRT creation tests

2025-07-26 07:37:03 +02:00

fwu_updates

FWU: Add platform hook support for fwu metata

2025-10-09 09:07:04 +02:00

libavb

lib: Remove duplicate newlines

2024-07-15 12:12:18 -06:00

libfdt

global: Rename SPL_TPL_ to PHASE_

2024-10-11 11:44:48 -06:00

lwip

net: lwip: enable debug traces for SNTP when CONFIG_LWIP_DEBUG is set

2025-09-30 12:01:36 +02:00

lzma

lib: Remove duplicate newlines

2024-07-15 12:12:18 -06:00

lzo

lib: Remove duplicate newlines

2024-07-15 12:12:18 -06:00

mbedtls

lib: use lowercase hex prefix style

2025-06-14 09:09:40 -06:00

optee

lib: optee: Add line ending to debug() outputs

2025-09-24 11:04:04 -06:00

rsa

lib/rsa: allow matching pkcs11 path by object id

2025-07-08 16:19:31 -06:00

zlib

zlib: annotate switch/case fallthrough cases

2025-04-08 16:23:51 -06:00

zstd

lib: Remove duplicate newlines

2024-07-15 12:12:18 -06:00

.gitignore

lib: ignore oid_registry_data.c file

2020-01-22 17:47:57 -05:00

abuf.c

abuf: Add a way to printf() into a buffer

2025-05-30 09:49:31 +01:00

addr_map.c

lib: Remove <common.h> inclusion from these files

2023-12-21 08:54:37 -05:00

aes.c

lib: Remove <common.h> inclusion from these files

2023-12-21 08:54:37 -05:00

alist.c

alist: Add a way to efficiently filter an alist

2024-11-03 21:27:12 -06:00

asm-offsets.c

global_data: Remove environment members if not used

2024-08-26 14:06:08 -06:00

asn1_decoder.c

common: Drop linux/printk.h from common header

2023-09-24 09:54:57 -04:00

bch.c

lib: Remove <common.h> inclusion from these files

2023-12-21 08:54:37 -05:00

binman.c

binman: Read the skip-at-start value on startup

2025-05-27 10:07:36 +01:00

bitrev.c

lib: bitrev: Sync with Linux kernel v4.17

2018-09-18 00:01:18 -06:00

charset.c

efi_loader: add an EFI variable with the file contents

2024-04-20 08:22:24 +02:00

circbuf.c

lib: Remove duplicate newlines

2024-07-15 12:12:18 -06:00

crc7.c

lib: Remove duplicate newlines

2024-07-15 12:12:18 -06:00

crc8.c

lib: Mark crc8 as relocation code

2025-02-03 16:01:36 -06:00

crc16-ccitt.c

lib: Remove <common.h> inclusion from these files

2023-12-21 08:54:37 -05:00

crc16.c

crc16: Move standard CRC-16 implementation from ubifs to lib

2022-04-21 14:32:40 -04:00

crc32.c

lib: Remove <common.h> inclusion from these files

2023-12-21 08:54:37 -05:00

crc32c.c

lib: Remove <common.h> inclusion from these files

2023-12-21 08:54:37 -05:00

ctype.c

SPDX: Convert all of our single license tags to Linux Kernel style

2018-05-07 09:34:12 -04:00

date.c

lib: Remove <common.h> inclusion from these files

2023-12-21 08:54:37 -05:00

display_options.c

global: Use CONFIG_XPL_BUILD instead of CONFIG_SPL_BUILD

2024-10-11 11:44:48 -06:00

div64.c

common: Drop linux/bitops.h from common header

2020-05-18 21:19:23 -04:00

elf.c

lib: move phdr increment to for loop heading

2024-08-27 18:01:21 -06:00

errno_str.c

lib: Remove <common.h> inclusion from these files

2023-12-21 08:54:37 -05:00

errno.c

sandbox: errno: avoid conflict with libc's errno

2021-05-24 14:21:30 -04:00

fdt-libcrypto.c

lib/rsa: Make fdt_add_bignum() available outside of RSA code

2021-04-14 15:06:08 -04:00

fdtdec_common.c

lib: Remove <common.h> inclusion from these files

2023-12-21 08:54:37 -05:00

fdtdec_test.c

lib: Remove <common.h> inclusion from these files

2023-12-21 08:54:37 -05:00

fdtdec.c

bloblist: fix the overriding of fdt from bloblist

2025-04-28 10:13:19 -06:00

fw_loader.c

fw_loader: Prefix the FW loader variables with the script prefix

2025-10-09 13:50:40 -06:00

getopt.c

lib: Remove <common.h> inclusion from these files

2023-12-21 08:54:37 -05:00

gunzip.c

bootm: improve error message when gzip decompression buffer is too small

2025-05-05 14:16:57 -06:00

gzip.c

Revert "Revert "Merge patch series "zlib: Address CVE-2016-9841"""

2024-07-05 13:57:02 -06:00

hang.c

global: Use CONFIG_XPL_BUILD instead of CONFIG_SPL_BUILD

2024-10-11 11:44:48 -06:00

hash-checksum.c

lib: Remove <common.h> inclusion from these files

2023-12-21 08:54:37 -05:00

hashtable.c

lib: hashtable: Prevent recursive calling of callback functions

2024-12-07 09:07:45 -03:00

hexdump.c

global: Use CONFIG_XPL_BUILD instead of CONFIG_SPL_BUILD

2024-10-11 11:44:48 -06:00

image-sparse.c

lib: sparse: Fix error checking for write_sparse_chunk_raw

2024-02-09 09:42:04 +01:00

Kconfig

fw_loader: Split from fs_loader into separate library file

2025-10-09 13:50:40 -06:00

ldiv.c

SPDX: Convert all of our single license tags to Linux Kernel style

2018-05-07 09:34:12 -04:00

linux_compat.c

lib: Remove <common.h> inclusion from these files

2023-12-21 08:54:37 -05:00

linux_string.c

strim: Sync up with Linux version

2025-05-16 06:21:36 +02:00

list_sort.c

lib: Remove <common.h> inclusion from these files

2023-12-21 08:54:37 -05:00

lmb.c

lmb: Remove unreachable code

2025-07-22 11:29:33 -06:00

lz4_wrapper.c

lib: Mark lz4 as relocation code

2025-02-03 16:01:36 -06:00

lz4.c

lz4: Do not disable LZ4_decompress_safe* for xPL

2025-10-10 14:25:33 -06:00

Makefile

fw_loader: Split from fs_loader into separate library file

2025-10-09 13:50:40 -06:00

md5.c

net: disable MBEDTLS in SPL

2024-12-06 17:47:23 -06:00

membuf.c

membuf: Minor code-style improvements

2025-04-03 16:54:49 -06:00

net_utils.c

net: net_utils: Move ip_to_string to lib/net_utils.c

2024-11-18 16:12:35 +01:00

of_live.c

abuf: Add a helper for initing and allocating a buffer

2025-05-30 09:49:31 +01:00

oid_registry.c

lib: add oid registry utility

2019-12-06 16:44:20 -05:00

panic.c

lib: Remove <common.h> inclusion from these files

2023-12-21 08:54:37 -05:00

physmem.c

lib: Remove <common.h> inclusion from these files

2023-12-21 08:54:37 -05:00

qsort.c

lib: Remove <common.h> inclusion from these files

2023-12-21 08:54:37 -05:00

rand.c

lib: Remove <common.h> inclusion from these files

2023-12-21 08:54:37 -05:00

rational.c

lib: rational: copy the rational fraction lib routines from Linux

2021-06-11 16:34:52 +05:30

rbtree.c

SPDX: Convert all of our single license tags to Linux Kernel style

2018-05-07 09:34:12 -04:00

rc4.c

lib: Remove <common.h> inclusion from these files

2023-12-21 08:54:37 -05:00

rtc-lib.c

lib: Remove <common.h> inclusion from these files

2023-12-21 08:54:37 -05:00

semihosting.c

lib: Remove <common.h> inclusion from these files

2023-12-21 08:54:37 -05:00

sha1.c

net: disable MBEDTLS in SPL

2024-12-06 17:47:23 -06:00

sha256_common.c

lib: sha256: move common function to sha256_common.c

2025-01-18 17:12:47 -06:00

sha256.c

lib: sha256: add feature sha256_hmac

2025-01-18 17:12:47 -06:00

sha512.c

net: disable MBEDTLS in SPL

2024-12-06 17:47:23 -06:00

slre.c

slre: implement support for ranges in character classes

2025-05-29 08:25:18 -06:00

smbios-parser.c

smbios: correctly name Structure Table Maximum Size field

2024-02-02 19:57:45 +01:00

smbios.c

smbios: Do not look up children of invalid nodes

2025-04-24 08:23:02 -06:00

sscanf.c

xen: Code style conformity

2020-08-24 14:11:31 -04:00

string.c

lib: implement strnstr()

2025-02-12 12:37:12 -06:00

strto.c

lib: provide function hextoull()

2024-11-13 08:14:23 -06:00

tables_csum.c

lib: make table_compute_checksum() arguments const

2024-01-09 10:08:52 +01:00

time.c

lib: time: hook uthread_schedule() into udelay()

2025-04-23 13:19:44 -06:00

tiny-printf.c

tiny-printf: Handle formatting of %p with an extra Kconfig

2025-05-22 10:57:12 -06:00

tpm_api.c

tpm: add TPM2_Shutdown command

2025-01-28 08:58:41 +02:00

tpm_tcg2.c

tpm: get tpm event log from bloblist

2025-01-28 09:09:32 +02:00

tpm-common.c

lib: Remove <common.h> inclusion from these files

2023-12-21 08:54:37 -05:00

tpm-utils.h

doc: replace @return by Return:

2022-01-19 18:11:34 +01:00

tpm-v1.c

sha1: Remove sha1 non-watchdog API

2024-10-14 17:58:30 -06:00

tpm-v2.c

tpm: Make use of TPM2_ALG_INVAL from enum

2025-07-01 08:46:38 +03:00

trace.c

lib/trace: drop volatile qualifier from "save gd" variables

2025-06-13 16:57:15 -06:00

uthread.c

uthread: add uthread_mutex

2025-04-23 13:19:44 -06:00

uuid.c

efi: Rename CONFIG_EFI to CONFIG_EFI_CLIENT

2025-07-26 07:34:28 +02:00

vsprintf.c

lib: vsprintf: fix API build

2024-11-13 08:16:41 -06:00

xxhash.c

lib: Add xxhash support

2019-05-05 08:48:50 -04:00