Ian Roberts 5f07144968
mmc: sdhci: Fix potential ADMA descriptor table overflow ...
Change ADMA_TABLE_NO_ENTRIES to round the division up to fully
contain CONFIG_SYS_MMC_MAX_BLK_COUNT, fixing potential buffer overflow
of the ADMA descriptor table.
sdhci_prepare_adma_table() expecitily states it does _not_ check for
overflow as the descriptor table size is dependent on
CONFIG_SYS_MMC_MAX_BLK_COUNT. However, the ADMA_TABLE_NO_ENTRIES
calculation does not round up the divison, so with the current u-boot
defaults:
max_mmc_transfer = (CONFIG_SYS_MMC_MAX_BLK_COUNT * MMC_MAX_BLOCK_LEN) =
65535 * 512 = 33553920 bytes.
ADMA_TABLE_NO_ENTRIES = max_mmc_transfer / ADMA_MAX_LEN =
33553920 / 65532, which does not divide cleanly.
actual_max_transfer = ADMA_TABLE_NO_ENTRIES * ADMA_MAX_LEN = 512 *
65532 = 33552384, which is smaller than max_mmc_transfer.
This can cause sdhci_prepare_adma_table() to write one extra
descriptor, overflowing the table when a transaction larger than
actual_max_transfer is issued.
Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com >
Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com >
Signed-off-by: Greg Malysa <greg.malysa@timesys.com >
Signed-off-by: Ian Roberts <ian.roberts@timesys.com >
Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com >
2024-04-26 15:31:00 +09:00
2024-04-22 11:01:48 -06:00
2024-03-29 10:39:25 -04:00
2024-04-23 13:29:25 +02:00
2023-09-24 09:54:57 -04:00
2024-01-24 11:12:11 -05:00
2024-04-04 18:48:46 +02:00
2024-03-17 18:39:21 -03:00
2024-02-08 09:17:46 -03:00
2023-11-07 14:50:52 -05:00
2023-11-07 14:49:40 -05:00
2024-04-22 11:01:48 -06:00
2023-10-15 12:23:48 +02:00
2023-11-16 12:43:48 -05:00
2024-01-03 09:22:47 -05:00
2024-03-14 18:19:44 +08:00
2023-10-16 15:46:18 +02:00
2024-04-23 13:29:32 +02:00
2023-12-28 12:02:56 -05:00
2024-04-12 12:57:07 -06:00
2023-12-01 14:06:04 +01:00
2023-08-25 13:54:33 -04:00
2023-11-07 18:36:06 -05:00
2023-07-17 15:39:55 -04:00
2023-08-08 10:22:03 -04:00
2023-08-08 10:22:03 -04:00
2023-12-21 08:54:37 -05:00
2024-02-15 10:38:34 +01:00
2023-11-12 16:47:16 +00:00
2023-11-16 18:59:58 -05:00
2023-10-24 15:55:17 +08:00
2023-11-18 10:08:08 +02:00
2024-02-29 09:24:22 -05:00
2023-11-07 14:50:52 -05:00
2023-12-13 11:51:53 -05:00
2024-03-04 10:25:47 -05:00
2024-04-18 08:29:35 -06:00
2023-08-25 17:55:19 -04:00
2023-12-21 08:54:05 -05:00
2023-12-13 11:51:24 -05:00
2024-02-13 15:38:49 -05:00
2023-10-24 16:34:45 -04:00
2023-11-02 22:38:01 -04:00
2023-08-25 13:54:33 -04:00
2024-03-21 06:56:13 +01:00
2023-12-28 12:02:56 -05:00
2023-10-11 15:43:54 -04:00
2024-01-29 22:35:02 -05:00
2024-01-29 22:35:02 -05:00
2024-01-16 17:05:29 -05:00
2023-09-24 09:54:57 -04:00
2024-01-09 14:58:33 +01:00
2024-03-21 06:56:13 +01:00
2024-03-21 06:56:13 +01:00
2023-11-10 11:01:50 -05:00
2023-10-24 16:34:45 -04:00
2024-01-24 11:12:11 -05:00
2023-11-07 14:50:51 -05:00
2024-04-21 09:07:00 +02:00
2024-04-02 09:08:07 +02:00
2024-04-02 09:08:07 +02:00
2024-01-07 13:45:07 -07:00
2023-07-15 11:20:41 +02:00
2024-04-20 08:22:24 +02:00
2023-11-07 14:50:52 -05:00
2024-04-13 11:03:12 +02:00
2024-04-20 08:22:24 +02:00
2024-04-08 13:03:34 +02:00
2023-07-16 23:13:17 +08:00
2024-04-12 14:53:13 +02:00
2023-12-21 08:54:05 -05:00
2024-01-19 10:57:36 +08:00
2023-10-23 17:07:06 +03:00
2023-10-11 15:43:55 -04:00
2023-11-16 18:53:09 -05:00
2023-10-17 20:50:52 -04:00
2024-04-18 08:29:35 -06:00
2024-04-19 07:28:24 -06:00
2023-11-28 20:10:24 -05:00
2024-04-21 09:07:02 +02:00
2024-01-07 13:45:07 -07:00
2023-11-07 14:50:52 -05:00
2023-09-21 13:20:11 +02:00
2023-11-07 14:50:52 -05:00
2023-11-07 14:50:52 -05:00
2023-11-07 14:50:52 -05:00
2023-11-07 14:50:51 -05:00
2023-11-07 14:50:52 -05:00
2023-11-07 14:50:52 -05:00
2023-11-07 14:50:52 -05:00
2024-01-13 18:17:47 +01:00
2023-11-10 11:01:50 -05:00
2023-12-21 08:54:37 -05:00
2024-04-08 13:04:48 +02:00
2024-01-24 11:12:11 -05:00
2024-01-24 11:12:11 -05:00
2023-10-31 09:08:51 +01:00
2023-07-25 12:44:46 -04:00
2024-04-11 09:38:57 -06:00
2024-04-05 09:39:18 -03:00
2024-02-08 09:01:22 -03:00
2024-03-01 14:44:35 +00:00
2023-09-14 10:42:24 -04:00
2023-11-02 16:22:06 +08:00
2023-12-21 11:59:49 -05:00
2023-11-07 14:50:52 -05:00
2023-08-19 04:12:53 +02:00
2023-11-10 11:01:50 -05:00
2024-03-13 10:10:04 -04:00
2024-03-13 10:10:04 -04:00
2023-11-07 14:50:52 -05:00
2023-12-13 11:35:13 -05:00
2023-11-07 14:50:52 -05:00
2023-08-15 18:21:17 +02:00
2024-03-02 12:26:56 -05:00
2024-01-07 13:45:07 -07:00
2024-04-12 16:23:06 -06:00
2023-12-21 08:54:37 -05:00
2024-01-09 14:58:33 +01:00
2023-10-11 15:43:55 -04:00
2023-11-07 14:50:52 -05:00
2023-08-08 10:22:03 -04:00
2024-04-15 15:19:12 +09:00
2023-11-07 14:50:51 -05:00
2023-11-10 11:01:50 -05:00
2023-11-10 11:01:50 -05:00
2023-11-07 14:50:52 -05:00
2023-11-16 12:43:49 -05:00
2023-12-21 08:54:37 -05:00
2023-11-18 10:08:09 +02:00
2023-10-06 14:38:13 -04:00
2024-01-24 11:12:11 -05:00
2023-08-30 17:56:21 -04:00
2023-10-06 14:38:13 -04:00
2023-11-16 12:43:49 -05:00
2023-11-07 14:50:52 -05:00
2023-08-25 17:55:19 -04:00
2024-01-21 11:24:24 +01:00
2024-03-26 19:58:26 -04:00
2024-01-18 20:24:13 -05:00
2024-03-26 19:58:26 -04:00
2023-11-07 14:50:52 -05:00
2024-01-24 11:12:11 -05:00
2023-09-14 10:42:24 -04:00
2024-03-22 15:50:28 -04:00
2023-10-24 15:55:17 +08:00
2024-03-02 12:26:19 -05:00
2023-12-21 08:54:37 -05:00
2023-08-29 13:37:54 -04:00
2023-10-10 16:19:43 -04:00
2023-10-15 12:23:48 +02:00
2023-11-07 18:36:06 -05:00
2023-10-24 17:05:24 -04:00
2023-10-13 16:59:23 -04:00
2023-10-24 17:05:24 -04:00
2023-11-07 18:36:06 -05:00
2024-04-26 15:31:00 +09:00
2023-09-15 23:38:02 +02:00
2023-11-07 13:47:08 +01:00
2023-10-15 12:23:48 +02:00
2023-10-15 12:23:48 +02:00
2024-03-27 09:23:30 +01:00
2024-01-24 11:12:11 -05:00
2024-01-24 11:12:11 -05:00
2023-11-07 14:50:52 -05:00
2023-11-16 13:49:14 -05:00
2024-01-29 14:49:17 -05:00
2023-10-09 15:24:31 -04:00
2023-10-22 23:41:46 +01:00
2024-01-24 11:12:11 -05:00
2023-12-21 08:54:37 -05:00
2024-01-09 10:08:52 +01:00
2023-11-07 14:50:52 -05:00
2023-09-15 23:38:02 +02:00
2023-11-10 11:01:50 -05:00
2023-09-09 06:12:47 +02:00
2024-01-24 11:12:11 -05:00
2023-10-27 13:14:47 +03:00
2024-04-04 10:45:27 +02:00
2023-11-07 14:50:52 -05:00
2023-11-07 14:50:52 -05:00
2023-11-07 14:50:52 -05:00
2024-03-22 10:16:13 +01:00
2024-04-05 03:25:14 +02:00
2023-11-07 14:50:52 -05:00
2023-08-25 17:55:18 -04:00
2023-07-21 09:00:38 +02:00
2024-03-21 06:56:13 +01:00
2023-11-14 20:04:00 -07:00
2023-09-21 13:20:10 +02:00
2023-07-21 09:00:38 +02:00
5f07144968