Mirrors/avrdude
1
0
Fork 0
mirror of https://github.com/avrdudes/avrdude.git synced 2026-10-01 05:18:45 +03:00
Code Issues Packages Projects Releases Wiki Activity

Always print error if part and programmer doesn't have a common programming interface (#1563)

Browse Source 
* Harmonize WIN32 implementation of serial time-outs with Posix

This is from @mariusgreuel in Issue #1249.
https://github.com/avrdudes/avrdude/issues/1249

> The WIN32 time-out is specified as ReadTotalTimeoutConstant + buflen * ReadTotalTimeoutMultiplier, which makes it potentially much longer than the Posix one (i.e. at least double). ReadIntervalTimeout is also set to timeout, which essentially renders the interval timeout ineffective, so IMHO, we should explicitly disable that feature.

* Update NEWS

* Always print error if part and programmer doesn't have a common programming interface
even though the user uses -F. It won't exit though.

* Don't mention -F in error message if -F is already used

---------

Co-authored-by: mcuee <xiaofanc@gmail.com>
Co-authored-by: Stefan Rueger <stefan.rueger@urclocks.com>
This commit is contained in:
Hans
2023-11-13 03:30:30 +01:00
committed by GitHub
parent fb550221c7
commit 71bf4f72a9
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/main.c
View File

@@ -1128,10 +1128,12 @@ int main(int argc, char * argv [])
exit(1);
}
if(!ovsigck && partdesc && (p = locate_part(part_list, partdesc)) && !(p->prog_modes & pgm->prog_modes)) {
pmsg_error("programmer %s cannot program part %s as they\n", pgmid, p->desc);
imsg_error("lack a common programming mode; use -F to override this check\n");
exit(1);
if(partdesc && (p = locate_part(part_list, partdesc)) && !(p->prog_modes & pgm->prog_modes)) {
pmsg_error("-c %s cannot program %s for lack of a common programming mode\n", pgmid, p->desc);
if(!ovsigck) {
imsg_error("use -F to override this check\n");
exit(1);
}
}
if (pgm->initpgm) {