Mirrors/avrdude
1
0
Fork 0
mirror of https://github.com/avrdudes/avrdude.git synced 2026-07-18 15:39:19 +03:00
Code Issues Packages Projects Releases Wiki Activity

Suppress gcc compiler warning

Browse Source 
For some reason gcc thinks q+3 might be out of bounds below. It isn't, but
adding the strlen(q) >= 3 condition suppresses the warning.

In function ‘sa_snmatch’,
    inlined from ‘sa_snmatch’ at /home/srueger/etc/clock/avrdude/gcc-warning/src/serialadapter.c:56:12,
    inlined from ‘sa_num_matches_by_ids’ at /home/srueger/etc/clock/avrdude/gcc-warning/src/serialadapter.c:190:48,
    inlined from ‘sa_unique_by_ids’ at /home/srueger/etc/clock/avrdude/gcc-warning/src/serialadapter.c:203:61,
    inlined from ‘sa_list_specs’ at /home/srueger/etc/clock/avrdude/gcc-warning/src/serialadapter.c:239:8,
    inlined from ‘sa_print_specs’ at /home/srueger/etc/clock/avrdude/gcc-warning/src/serialadapter.c:253:19:
/home/srueger/etc/clock/avrdude/gcc-warning/src/serialadapter.c:57:63: warning: array subscript 3 is outside array bounds of ‘char[1]’ [-Warray-bounds=]
   57 |   return sn && (str_starts(sn, q) || (str_starts(q, "...") && str_ends(sn, q + 3)));
      |                                                               ^~~~~~~~~~~~~~~~~~~
This commit is contained in:
Stefan Rueger
2026-06-13 01:31:14 +01:00
parent f0db889825
commit 8730b145c8
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/serialadapter.c
View File

@@ -54,7 +54,8 @@ static int sa_setport(char **portp, const char *sp_port) {
// Is the actual serial number sn matched by the query q?
static int sa_snmatch(const char *sn, const char *q) {
return sn && (str_starts(sn, q) || (str_starts(q, "...") && str_ends(sn, q + 3)));
return sn && (str_starts(sn, q) ||
(str_starts(q, "...") && strlen(q) >= 3 /* suppress gcc warning */ && str_ends(sn, q + 3)));
}
#define null_len(s) ((s)? strlen(s): 0)