Mirrors/u-boot
1
0
Fork 0
mirror of https://source.denx.de/u-boot/u-boot.git synced 2026-06-13 15:03:58 +03:00
Code Issues Packages Projects Releases Wiki Activity

firmware: scmi: smt: Dump more info

Browse Source 
"Buffer too small" is too vague, dump more info to make it easier to
debug issues.
Change dev_dbg to dev_err when buffer is too small.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
This commit is contained in:
Peng Fan
2025-09-27 00:06:16 +08:00
committed by Tom Rini
parent 8c48bae4f5
commit 23e2b76922
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/firmware/scmi/smt.c
View File

@@ -92,7 +92,9 @@ int scmi_write_msg_to_smt(struct udevice *dev, struct scmi_smt *smt,
if (smt->size < (sizeof(*hdr) + msg->in_msg_sz) ||
smt->size < (sizeof(*hdr) + msg->out_msg_sz)) {
dev_dbg(dev, "Buffer too small\n");
dev_err(dev,
"Buffer write too small: mst->size:%zu, in_msg_sz:%zu, out_msg_sz:%zu\n",
smt->size, msg->in_msg_sz, msg->out_msg_sz);
return -ETOOSMALL;
}
@@ -130,7 +132,8 @@ int scmi_read_resp_from_smt(struct udevice *dev, struct scmi_smt *smt,
}
if (ioread32(&hdr->length) > msg->out_msg_sz + sizeof(hdr->msg_header)) {
dev_err(dev, "Buffer too small\n");
dev_err(dev, "Buffer too small: hdr->length:%u, out_msg_sz:%zu\n",
ioread32(&hdr->length), msg->out_msg_sz);
return -ETOOSMALL;
}
@@ -167,7 +170,8 @@ int scmi_msg_to_smt_msg(struct udevice *dev, struct scmi_smt *smt,
if (smt->size < (sizeof(*hdr) + msg->in_msg_sz) ||
smt->size < (sizeof(*hdr) + msg->out_msg_sz)) {
dev_dbg(dev, "Buffer too small\n");
dev_err(dev, "Buffer too small: mst->size:%zu, in_msg_sz:%zu, out_msg_sz:%zu\n",
smt->size, msg->in_msg_sz, msg->out_msg_sz);
return -ETOOSMALL;
}
@@ -193,7 +197,8 @@ int scmi_msg_from_smt_msg(struct udevice *dev, struct scmi_smt *smt,
struct scmi_smt_msg_header *hdr = (void *)smt->buf;
if (buf_size > msg->out_msg_sz + sizeof(hdr->msg_header)) {
dev_err(dev, "Buffer too small\n");
dev_err(dev, "Buffer too small: buf_size:%zu, out_msg_sz:%zu\n",
buf_size, msg->out_msg_sz);
return -ETOOSMALL;
}