mirror of
https://source.denx.de/u-boot/u-boot.git
synced 2026-06-13 15:03:58 +03:00
smbios: Correct error handling when writing tables
Since write_smbios_table() returns an address, we cannot use it to
return and error number. Also, failing on sysinfo_detect() breaks
existing boards, e.g. chromebook_link
Correct this by logging and swallowing the error.
Signed-off-by: Simon Glass <sjg@chromium.org>
Fixes: a5a5756285 ("lib: smbios: Detect system properties via...")
This commit is contained in:
10
lib/smbios.c
10
lib/smbios.c
@@ -5,6 +5,8 @@
|
||||
* Adapted from coreboot src/arch/x86/smbios.c
|
||||
*/
|
||||
|
||||
#define LOG_CATEGORY LOGC_BOARD
|
||||
|
||||
#include <dm.h>
|
||||
#include <env.h>
|
||||
#include <linux/stringify.h>
|
||||
@@ -596,8 +598,12 @@ ulong write_smbios_table(ulong addr)
|
||||
|
||||
parent_node = dev_read_subnode(ctx.dev, "smbios");
|
||||
ret = sysinfo_detect(ctx.dev);
|
||||
if (ret)
|
||||
return ret;
|
||||
|
||||
/*
|
||||
* ignore the error since many boards don't implement
|
||||
* this and we can still use the info in the devicetree
|
||||
*/
|
||||
ret = log_msg_ret("sys", ret);
|
||||
}
|
||||
} else {
|
||||
ctx.dev = NULL;
|
||||
|
||||
Reference in New Issue
Block a user