Mirrors/u-boot
1
0
Fork 0
mirror of https://source.denx.de/u-boot/u-boot.git synced 2026-06-13 15:03:58 +03:00
Code Issues Packages Projects Releases Wiki Activity

net: rswitch: Fix error detection

Browse Source 
In rswitch_probe the error detection after the call to devm_clk_get is
very wrong. It checks the value of ret which is uninitialised at that
point. Instead it should be using the macros for including errors into
pointers.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
Reviewed-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
This commit is contained in:
Andrew Goodbody
2025-08-06 11:19:11 +01:00
committed by Marek Vasut
parent 393ace55be
commit 6c49b082f0
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/rswitch.c
View File

@@ -1110,8 +1110,10 @@ static int rswitch_probe(struct udevice *dev)
return -EINVAL;
priv->rsw_clk = devm_clk_get(dev, NULL);
if (ret)
if (IS_ERR(priv->rsw_clk)) {
ret = PTR_ERR(priv->rsw_clk);
goto err_map;
}
ret = clk_prepare_enable(priv->rsw_clk);
if (ret)